Skip to content

Update workflows to use artifact actions v4 and replace the archived workflow … - #20

Merged
Amndeep7 merged 10 commits into
masterfrom
update-actions-to-v4
Jan 15, 2025
Merged

Amndeep7 merged 10 commits into
masterfrom
update-actions-to-v4

Conversation

@jtquach1

@jtquach1 jtquach1 commented Dec 12, 2024 •

Copy link
Copy Markdown
Contributor

…actions/setup-ruby@v1 with ruby/setup-ruby@v1

Changes made

  • Updating artifact actions v3 to v4 since v3 will be deprecated 1/30/2025.
  • Also actions/setup-ruby is archived and has been recommended instead to use ruby/setup-ruby
  • actions/cache is recommended to be updated from v2 to either v3 or v4 (picked v4)

…actions/setup-ruby@v1 with ruby/setup-ruby@v1

Signed-off-by: Joyce Quach <jquach@mitre.org>
Signed-off-by: Joyce Quach <jquach@mitre.org>
@jtquach1 jtquach1 changed the title Update workflows to use actions v4 and replace the archived workflow … Update workflows to use artifact actions v4 and replace the archived workflow … Dec 12, 2024
Signed-off-by: Joyce Quach <jquach@mitre.org>
Signed-off-by: Joyce Quach <jquach@mitre.org>
Signed-off-by: Joyce Quach <jquach@mitre.org>
Signed-off-by: Joyce Quach <jquach@mitre.org>
Comment thread .github/workflows/verify-docker.yml Outdated
@Amndeep7

Copy link
Copy Markdown
Contributor

the docker one claims that it's passing, but it is actually also failing
image

jtquach1 and others added 4 commits January 14, 2025 16:49
Signed-off-by: Joyce Quach <jquach@mitre.org>
Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
Signed-off-by: Amndeep Singh Mann <amann@mitre.org>

@Amndeep7 Amndeep7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed problems with everything other than the ec2 profile failing due to the vpc issue which is already being tracked by Daniel

@Amndeep7
Amndeep7 merged commit 359db42 into master Jan 15, 2025
@Amndeep7
Amndeep7 deleted the update-actions-to-v4 branch January 15, 2025 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants