-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checklist metadata validation and checklist mapper severities #2750
Merged
Merged
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
0e7a273
input validation for checklist metadata
kemley76 0d5fd2c
use hdf-converters in hdf2ckl
kemley76 f0a2dac
updated hdf2ckl tests
kemley76 71d53c7
update tests based on changes to ckl mapper
kemley76 f1d09e3
update ckl metadata validation to use hdf-converters helper function
kemley76 dd3fbd3
added ability to use local install of inspecjs
kemley76 1999bd5
update checklist commands and tests
kemley76 0ff6be4
ensure threshold counts stay based off impact
kemley76 69e94c0
added tests to ensure that converting with invalid metadata display a…
kemley76 5d2ffda
use checklist types from hdf-converters
kemley76 16e1bc6
remove redundant code in hdf2ckl command
kemley76 4cfe734
use inspecJS to convert impact to severity
kemley76 4482231
use checklist types from hdf-converters
kemley76 0711ff6
Merge branch 'hdf2ckl-severity-update' into update-hdf-converters
kemley76 6eaf79e
fix test data
kemley76 302e731
Merge branch 'main' into update-hdf-converters
kemley76 1da2b0f
enforce enum matching for user input in generate ckl_metadata command
kemley76 c4de62d
add backwards compatibility for old checklist metadata format
kemley76 b3d4724
Merge branch 'main' into update-hdf-converters
kemley76 72c8f39
remove debug statement
kemley76 02b21d2
fix code smells
kemley76 11991ca
linting
kemley76 5a091f4
format every output json file with 2 space indent
kemley76 e540f79
add flags for all metadata fields on hdf2ckl command
kemley76 c531d2b
clarify instructions on ckl metadata generation
kemley76 83c98f1
change formating from 4 to 2 space indent
kemley76 14aa7be
make version and release number optional in checklist metadata genera…
kemley76 9500d89
update tests to reflect better formatted error messages
kemley76 a84c21a
update markdown summary table to include row for severity: none
kemley76 4de13d1
update code and tests to count N/A controls with severity other than …
kemley76 81a36bb
Merge branch 'main' into update-hdf-converters
kemley76 b4fa9f6
fix code smells
kemley76 7ad5e57
revert addition of severity-none row to markdown summary table
kemley76 be94295
Merge branch 'main' into update-hdf-converters
Amndeep7 61e1dff
remove heimdall version when running checklist tests
kemley76 a6b99b5
change return type of string | undefined to string | null
kemley76 2f5f496
refactor to avoid while true loops
kemley76 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm not familiar enough with threshold files to know if the changes you're making here are appropriate. please get @aaronlippold / @wdower / @ejaronne to confirm if this is alright.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a discussion with @aaronlippold and @wdower regarding this table. There is no need to have a row for severity "none" because it should not be possible for there to be severity "none". Every mapper should define a severity, especially in the case when status is not applicable, because then impact would be 0 leading to severity "none".
I have reverted my changes, but the option for
RowType: 'Not Applicable'
has been removed because it is never used and does not need to be used because there is a column that represents this.The script that generates this kind of table may need to be updated to reflect the possibility of there being N/A controls with severity critical, high, medium, or low.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make a new issue for this task @kemley76