Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the issue #404 #475

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Fix the issue #404 #475

wants to merge 6 commits into from

Conversation

miurahr
Copy link
Owner

@miurahr miurahr commented Aug 3, 2022

Reproduce #404

@miurahr miurahr marked this pull request as draft August 3, 2022 06:40
@miurahr
Add reproducible of issue 404
57c4759 
Signed-off-by: Hiroshi Miura <[email protected]>
@miurahr
Update expectation
241ff93 
Signed-off-by: Hiroshi Miura <[email protected]>
@miurahr
Update files_info reader
671ced7 
Re-calculate emptyfiles array after read header.

Signed-off-by: Hiroshi Miura <[email protected]>
@miurahr
Test: more assertions
d0fb2d4 
Signed-off-by: Hiroshi Miura <[email protected]>
@miurahr
Add more asserts
6928c83 
Signed-off-by: Hiroshi Miura <[email protected]>
@miurahr
Copy link
Owner Author

miurahr commented Oct 16, 2022

All the expectations are passed, but p7zip failed to extract the crated archive with CRC error.
The error is happened on entry a mid of appended files, so it is not clear what make trigger the bug.

@miurahr miurahr changed the title Add reproducible of issue 404 Fix the issue #404 Nov 5, 2022
@miurahr miurahr added the bug Something isn't working label Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@miurahr