Skip to content

Add specific setup instructions for Vue users#398

Open
a-toms wants to merge 1 commit intomixmark-io:masterfrom
a-toms:patch-1
Open

Add specific setup instructions for Vue users#398
a-toms wants to merge 1 commit intomixmark-io:masterfrom
a-toms:patch-1

Conversation

@a-toms
Copy link
Copy Markdown

@a-toms a-toms commented Sep 11, 2021

Copy link
Copy Markdown

@srbala srbala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Collaborator

@domchristie domchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might be a more general issue with ES6 imports rather than a Vue-specific problem. Perhaps we need to update package.json?

@srbala
Copy link
Copy Markdown

srbala commented Nov 27, 2021

If update to package.json solves the problem, that would be nice. This is PR is documentation update, anyone facing similar issue can resolve from it.

@pavelhoral
Copy link
Copy Markdown
Collaborator

pavelhoral commented Nov 28, 2021

This feels incorrect - the issue in the linked SO question seems to be with RequireJS and not at all connected with VueJS. So maybe you were not using the correct JS file (lib/turndown.browser.umd.js)?

For usage with RequireJS, UMD versions are located in lib/turndown.umd.js (for Node.js) and lib/turndown.browser.umd.js for browser usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants