Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move track commands #678

Open
wants to merge 3 commits into
base: 2.5
Choose a base branch
from
Open

Move track commands #678

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2891c47
move track controls
Jun 19, 2024
7c0a458
rewording track up/down
Jun 20, 2024
1e9050d
movetrack command
Jun 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions source/chapters/appendix/mixxx_controls.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3174,6 +3174,26 @@ Note that :mixxx:coref:`[Library],MoveUp` and other Move and Scroll controls emu
.. versionadded:: 2.1.0


.. mixxx:control:: [Library],MoveTrackUp

Equivalent to pressing the :kbd:`Alt` + :kbd:`Up` key on the keyboard
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure everyone browsing these controls is aware of the new Alt move feature.
I suggest to add more context here in order to make this feature more discoverable.
For example:

Move the track selection up by one row. This is applicable only in (unlocked) Playlists.

Same for down and MoveTrack.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reworded a bit both texts, what do you think?


:range: Binary
:feedback: Move selected track up
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or put it here (but maybe the explanation is to much for the 'feedback' hint):

Track selection is moved up by one row

What do you think?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reworded it so it's a bit more like other entries


.. versionadded:: 2.5.0


.. mixxx:control:: [Library],MoveTrackDown

Equivalent to pressing the :kbd:`Alt` + :kbd:`Down` key on the keyboard

:range: Binary
:feedback: Move selected track down

.. versionadded:: 2.5.0


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the controls seem to be ordered alphabetically, but actually it's better to have them grouped by 'function'/effect. Please move the block down so MoveVertical is below MoveUp again.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sure, I didn''t realize it was related

.. mixxx:control:: [Library],MoveVertical

Move the specified number of locations up or down. Intended to be mapped to an encoder knob.
Expand Down
Loading