-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
S4MK3: add support for screens #703
base: main
Are you sure you want to change the base?
Conversation
@ywwg I would really appreciate a review if you can! :) |
|
||
By default, the screens are standalone, meaning they do not interact with the device states. This means that local state such as deck selection or shifting will not trigger any screen interaction, and thus you should expect only Deck A and B to be displayed on these screen by default, although this can be changed in the controller settings. | ||
|
||
.. note:: it exists an API that was temporary parked that allows mappings to communicate. If you want, you may build a version of Mixxx with feature and you should be able to enable the feature in the controller settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a link to the branch/PR.
If someone is willing to try this it should be as easy as possible IMO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, it's mentioned at line 448
@@ -133,21 +144,26 @@ Moves modes define how the "move" encoder (the one on the left) reacts when used | |||
2. **Grid**: The track's detected beats will be move forward or backward on the waveform. | |||
3. **BPM**: The track's detected BPM will be increased or decreased. | |||
4. **Keyboard**: The keyboard's keys displayed on pads get moved up or down to display higher or lower keynotes. | |||
5. **Hotcue color**: When selecting a hotcue, the move encoder can be used to change the selected color. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While the hotcue button is pressed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, it's explained below..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO it would be better to explain the modes first then refer to them in each component section.
@@ -384,9 +423,9 @@ Mapping options | |||
|
|||
There are various option that can be used to change some behavior: | |||
|
|||
============================================================================================== =========================================== ================================================================================================================= ===================================================================================== ================================================================================================================================================================================================================ | |||
============================================================================================== =========================================== ================================================================================================================= ===================================================================================== ====================================================================================================================================================================================================================================== | |||
Setting Variable value Default Range Description |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My experience with this table:
- the content is very wide and I have to scroll horizontally to check the description for example
- I don't need the
Variable value
column. If I'd be interested, I'd look at the settings in the js file
-> this would reduce the table width - in the
Default
column we may remove the the prefix (LEDColors etc.) and just show the values
-> this would reduce the table width
Related to mixxxdj/mixxx#13653