-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hercules inpulse 500 manual #725
base: main
Are you sure you want to change the base?
Conversation
05675cf
to
6595b57
Compare
Thanks for the documentation but we add manuals only for built-in mappings. |
Hey, yes, I'm about to do the PR, I've been in talks with m0db about this. I thought you first had to submit the manual before the PR with the mapping, but it will be in the next hour up and ready too. |
Ah okay, great! |
It looks like there is a problem with the base of the PR - could you please rebase it? You should be able to do the following
Let me know if you would like some help on this |
or simpy mark all unrelated lines and remove them (Ctrl+K I think) |
6595b57
to
d19300e
Compare
---------------- | ||
|
||
This controller has built-in 4 channel output sound card, with MAIN | ||
output (RCA) and HEADPHONE output (3.5mm jack). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be:
with MAIN output (2x RCA or 2x unbalanced mono 6.35mm jack) and HEADPHONE output (stereo 3.5mm jack or stereo 6.35mm jack)
Minor nitpick about the outputs, for the rest it looks all correct and clear. Great job! |
@resetreboot I edited your first comment to point to the MR with the mappings. |
Here's a simple SVG in case you have interest to add and annotate it |
Thank you @ronso0 I will be looking how to add the SVG's and add some for extra clarifications. |
Manual for the mapping submitted with MR mixxxdj/mixxx#14316 (originally https://github.com/resetreboot/herimp-500map) and discussed at https://mixxx.discourse.group/t/hercules-djcontrol-inpulse-500/19739/111
Preview: https://deploy-preview-725--mixxx-manual.netlify.app/hardware/controllers/hercules_djcontrol_inpulse_500