Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hercules inpulse 500 manual #725

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

resetreboot
Copy link

@resetreboot resetreboot commented Feb 9, 2025

@resetreboot resetreboot force-pushed the hercules-inpulse-500-manual branch from 05675cf to 6595b57 Compare February 9, 2025 17:09
@ronso0
Copy link
Member

ronso0 commented Feb 9, 2025

Thanks for the documentation but we add manuals only for built-in mappings.
Is there a pending mapping PR for the Inpulse 500 at mixxxdj/mixxx that I missed?

@ronso0 ronso0 marked this pull request as draft February 9, 2025 17:14
@resetreboot
Copy link
Author

Hey, yes, I'm about to do the PR, I've been in talks with m0db about this. I thought you first had to submit the manual before the PR with the mapping, but it will be in the next hour up and ready too.

@ronso0
Copy link
Member

ronso0 commented Feb 9, 2025

Ah okay, great!
It's just that there should be a manual PR accompanying the mapping PR so that we can merge both at once.

@acolombier acolombier changed the base branch from main to 2.5 February 10, 2025 09:30
@acolombier acolombier changed the base branch from 2.5 to main February 10, 2025 09:30
@acolombier
Copy link
Member

acolombier commented Feb 10, 2025

It looks like there is a problem with the base of the PR - could you please rebase it?

You should be able to do the following

  • git rebase -i upstream/main, assuming 'upstream' is the name of the https://github.com/mixxxdj/manual remote
  • Set all the commit to drop or d, except 6595b57 which should remain pick
  • git push -f

Let me know if you would like some help on this

@ronso0
Copy link
Member

ronso0 commented Feb 10, 2025

Set all the commit to drop or d

or simpy mark all unrelated lines and remove them (Ctrl+K I think)

@resetreboot resetreboot force-pushed the hercules-inpulse-500-manual branch from 6595b57 to d19300e Compare February 12, 2025 15:57
@resetreboot resetreboot marked this pull request as ready for review February 12, 2025 15:57
----------------

This controller has built-in 4 channel output sound card, with MAIN
output (RCA) and HEADPHONE output (3.5mm jack).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be:

with MAIN output (2x RCA or 2x unbalanced mono 6.35mm jack) and HEADPHONE output (stereo 3.5mm jack or stereo 6.35mm jack)

@m0dB
Copy link

m0dB commented Feb 13, 2025

Minor nitpick about the outputs, for the rest it looks all correct and clear. Great job!

@m0dB
Copy link

m0dB commented Feb 13, 2025

@resetreboot I edited your first comment to point to the MR with the mappings.

@ronso0
Copy link
Member

ronso0 commented Feb 13, 2025

Here's a simple SVG in case you have interest to add and annotate it
Hercules-DJInpulse500
Hercules-DJInpulse500.svg.zip

@resetreboot
Copy link
Author

Thank you @ronso0 I will be looking how to add the SVG's and add some for extra clarifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants