[DRAFT] resolve-from-urls

[m0dB]

resolveTrackIdsFromUrls directly, without going through DragAndDropeHlper::supportedTracksFromUrls

[mxmilkiib]

Could this eventually lead to the possibility of pasting YouTube URLs into Mixxx to pull, convert and load audio into the next available deck? (an aspect of #6277)

[daschuer]

This is still draft, move form 2.5-beta milestone?

[m0dB]

Could this eventually lead to the possibility of pasting YouTube URLs into Mixxx to pull, convert and load audio into the next available deck? (an aspect of #6277)

I don't think so...

[m0dB]

This is still draft, move form 2.5-beta milestone?

It is draft because I find it the surrounding code hard to understand. The sole purpose of this change is to fix #13100 , and it looks to me that it does, but I find it hard to say if it is the right solution (also because @ronso0 suggested other approaches) and to predict if this can have negative side effects.

I don't think we want to revert the tracklist shortkey handling for 2.5, as it is a very nice and very "announcable" improvement, but @ronso0 considers a #13100 a blocker (I think I agree), so it should be fixed.

I am not quite sure how to proceed... Who would be the most familiar with the surrounding code?

[ronso0]

gonna take a in-detail look soonish.
think this could slip in during beta IMOH (regression fix etc.)

[m0dB]

Did you have a change to look at this @ronso0 ? Or do you think there is a better way to fix #13100 ?

[ronso0]

Well, it works as desired now, thanks!

I also have a hard time double-checking all callers, and I didn't spent time on an alternative fix.
Changes LGTM from what I can tell, but @daschuer's review is still open?

[ronso0]

I changed the base branch to 2.5, now that 2.6 has been split off.

[ronso0]

Yes, LGTM.
I propose to remove the Draft state and get this into 2.5-beta.

@daschuer What do you think?

[daschuer]

This PR will allow to add any URL to the database regardless if it is a playable file or any other random address. I this the intended behavior? To reference streaming tracks for instance?

[ronso0]

@m0dB @daschuer How shall we proceed here?
Can we still get this into 2.5, with the fixup I proposed?
Or should we add the 'bug' to the "Known issues" for 2.5.0 and try to get in into 2.5.1?

[daschuer]

I consider this is as "ready for merge" with your fix in place. @m0dB will you have time to prepare that for merge?

[m0dB]

Added the change suggested by @daschuer and rebased on 2.5.

[m0dB]

Sorry, having issues pushing:

Details

ts-source-copy...........................................................Failed

• hook id: ts-source-copy
• exit code: 1

Source copy found at: res/translations/mixxx_es_CR.ts:7858
Beat grid opacity
Source copy found at: res/translations/mixxx_es_EC.ts:7858
Beat grid opacity
Source copy found at: res/translations/mixxx_es_PA.ts:7858
Beat grid opacity
Source copy found at: res/translations/mixxx_es_UY.ts:7857
Beat grid opacity
Source copy found at: res/translations/mixxx_fr.ts:2410
Double BPM
Source copy found at: res/translations/mixxx_it.ts:2419
Tempo Tap
Source copy found at: res/translations/mixxx_it.ts:7894
pt
Source copy found at: res/translations/mixxx_it.ts:11505
Auto Makeup Gain
Source copy found at: res/translations/mixxx_it.ts:11510
Makeup
Source copy found at: res/translations/mixxx_it.ts:11522
Off
Source copy found at: res/translations/mixxx_it.ts:11527
On
Source copy found at: res/translations/mixxx_it.ts:11566
Knee (dBFS)
Source copy found at: res/translations/mixxx_it.ts:11571
Knee
Source copy found at: res/translations/mixxx_it.ts:13106
Speed Up
Source copy found at: res/translations/mixxx_it.ts:13171
Tempo Tap
Source copy found at: res/translations/mixxx_it.ts:16206
Okay
Source copy found at: res/translations/mixxx_it.ts:16267
Clear
Source copy found at: res/translations/mixxx_nl.ts:5476
Multi-Sampling
Source copy found at: res/translations/mixxx_nl.ts:7696
Top
Source copy found at: res/translations/mixxx_nl.ts:7894
pt
Source copy found at: res/translations/mixxx_nl.ts:8718
Track Editor
Source copy found at: res/translations/mixxx_nl.ts:8723
Title
Source copy found at: res/translations/mixxx_nl.ts:8829
&Reset
Source copy found at: res/translations/mixxx_nl.ts:11497
Compressor
Source copy found at: res/translations/mixxx_nl.ts:11502
Auto Makeup Gain
Source copy found at: res/translations/mixxx_nl.ts:11507
Makeup
Source copy found at: res/translations/mixxx_nl.ts:11544
Ratio (:1)
Source copy found at: res/translations/mixxx_nl.ts:11549
Ratio
Source copy found at: res/translations/mixxx_nl.ts:11563
Knee (dBFS)
Source copy found at: res/translations/mixxx_nl.ts:11568
Knee
Source copy found at: res/translations/mixxx_nl.ts:11594
Release (ms)
Source copy found at: res/translations/mixxx_nl.ts:11599
Release
Source copy found at: res/translations/mixxx_nl.ts:13167
Tempo Tap
Source copy found at: res/translations/mixxx_nl.ts:16346
title

All disallowed copied source translations need to be removed at
https://app.transifex.com/mixxx-dj-software and pulled again.
If they are intended untranslated use:
res/translations/source_copy_allow_list_proposed.tsv
to allow it.

I created a clean branch of 2.5 and will create a new PR to replace this one.

[m0dB]

#13958 replaces this one. I will close this when that one is merged.

[daschuer]

Close in favor of #13958