feat(controllers): add controller settings for the Numark Scratch#13404
feat(controllers): add controller settings for the Numark Scratch#13404Swiftb0y merged 1 commit intomixxxdj:2.5from
Conversation
Swiftb0y
left a comment
Swiftb0y
left a comment
There was a problem hiding this comment.
LGTM. I don't have much experience with the settings though. Do you spot anything wrong @acolombier?
acolombier
left a comment
acolombier
left a comment
There was a problem hiding this comment.
Glad to see this feature being used. Just added some very minor comments, otherwise LGTM
|
@acolombier this is ready. @Swiftb0y can someone please merge the 2.4 manual into 2.5, so I can update the controller manual. |
There was a problem hiding this comment.
Unfortunately, the beatloop value half and double cannot be used without some special handling, since beatlooproll_half_activate and beatlooproll_double_activate don't exist (and wouldn't make sense)
The handling should be fairly easy to add here
Done ;) |
|
@acolombier I reverted my last commit. Thinking about this more the mixer has only 4 pads instead of 8 and using up 2 pads might not be ideal. Let's merge as is and ill investigate more if it's worth it when I'm back from holidays. |
|
Oops clicked the dreaded comment and close by mistake. |
|
Great. Can you do me a favor and rebase out the reverted commit so it doesn't unnecessarily end up in the commit history? |
alhadebe
force-pushed
the
NumarkScratchSettings
branch
6 times, most recently
from
341bc38 to
6d5cd6a
Compare
3 participants
add controller settings for the Numark Scratch , inspired by the s4mk3