(fix) Traktor Kontrol S4 Mk3: revert QuickEffect preset offset

[ronso0]

0 is now the empty item ---
1 is the first item etc.

To clarify:
previously [1] would select the 3rd item = preset 2
now [1] selects preset 1

[acolombier]

The reason why 0 was removed is because, as per the doc, 0 will unselect the quick FX, so when assigning FX 1 to a deck (or a stem starting from #13653), which made a very poor user experience.
If you think this should still be possible, please make that a configurable setting.

[ronso0]

Yeah, I thinks it's fixed now.
@acolombier please take a look.

[ronso0]

The reason why 0 was removed is because, as per the doc, 0 will unselect the quick FX, so when assigning FX 1 to a deck (or a stem starting from #13653), which made a very poor user experience. If you think this should still be possible, please make that a configurable setting.

Umm, without this fix [1] would select the 3rd item (preset 2).
I just tested it again: [1] now selects preset 1, --- can't be selected.

[acolombier]

Right, looking at FXSelect, it looks like the computation always return 1 indeed. I'm AFK now, but I will test that later. I cannot remember why I added that offset, but it could also have been the initial Be's mapping definition.

[ronso0]

Yes, back then there was no --- item.

[acolombier]

Tested and work as expected! Thank you