Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish 2.5.0 Changelog #14048

Merged
merged 2 commits into from
Dec 22, 2024
Merged

Polish 2.5.0 Changelog #14048

merged 2 commits into from
Dec 22, 2024

Conversation

daschuer
Copy link
Member

I have reorganized it a bit and removed refactoring PRs that are not of interest for a regular user.
This shall match earlier enties where we have the same level of details.

@daschuer daschuer added this to the 2.5.0 milestone Dec 22, 2024
Copy link
Member

@ywwg ywwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great! I didn't find any grammar issues to make comments about and it describes the new stuff well.

<ul>
<li>
CMakeLists: Support building for iOS
iOs support: Mixxx can be build for iOs
Copy link
Member

@ywwg ywwg Dec 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apple writes it this way:

Suggested change
iOs support: Mixxx can be build for iOs
iOS support: Mixxx can be built for iOS

@daschuer
Copy link
Member Author

Done

@ronso0
Copy link
Member

ronso0 commented Dec 22, 2024

LGTM too!

@acolombier
Copy link
Member

LGTM! Thank you!

@acolombier acolombier merged commit 518d5e0 into mixxxdj:2.5 Dec 22, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants