Hercules DJ Control Starlight: Add EffectChain superknob control#14126
Merged
acolombier merged 3 commits intomixxxdj:mainfrom Feb 12, 2025
Merged
Hercules DJ Control Starlight: Add EffectChain superknob control#14126acolombier merged 3 commits intomixxxdj:mainfrom
acolombier merged 3 commits intomixxxdj:mainfrom
Conversation
Member
|
Welcome at Mixxx! |
Contributor
Author
|
Done. |
acolombier
approved these changes
Feb 12, 2025
Member
acolombier
left a comment
There was a problem hiding this comment.
Code LGTM!
Thanks for your contribution @konstruktiv and welcome to the team!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds controls for moving the metaknobs of all effects in the chain by holding the SHIFT button and turning the Bass/Filter knob.