Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(pre-commit): Fix failing codespell hook in desktop file #14169

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

Holzhaus
Copy link
Member

The codespell hook is failing due to translations. This was introduced in PR #14153. This commits excludes the file from the codespell check.

The codespell hook is failing due to translations. This was introduced
in PR mixxxdj#14153. This commits excludes the file from the codespell check.
@Holzhaus Holzhaus added code quality bug developer-experience Issues, bugs and PRs related to the development process, development environme labels Jan 13, 2025
@Holzhaus Holzhaus changed the base branch from main to 2.5 January 13, 2025 22:28
@daschuer
Copy link
Member

All green. LGTM
Thank you for backing me up..

@daschuer daschuer merged commit 82b676d into mixxxdj:2.5 Jan 13, 2025
13 checks passed
@JoergAtGithub
Copy link
Member

Yes, this looks correct. I thought the warning wouldn't appear after merging, as precommit just checks changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug code quality developer-experience Issues, bugs and PRs related to the development process, development environme
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants