-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the Twister a 4 deck controller #14557
base: 2.5
Are you sure you want to change the base?
Conversation
ea205d9
to
50bac15
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not replace semantic XML mapping by scripting if it is not technically mandatory. As semantic mapping is machine readable and easy to modify by users.
It is not possible to make this a 4 deck controller (which is done as part of this PR) with only an XML mapping, nor will it be possible to add a full effects control system later, or improve the LED usage, which is what I'd like to do with this controller. EDIT: I've updated the title to make it clearer what this does, as I'm assuming that is what got read that made it look like it was a change just to how the mappings worked. |
This does not change any functionality by default except that the LED below each button automatically becomes an indicator letting you know the controller is centered. It does, however, change the entire binding over to use ComponentJS which in turn allows us to use two of the side buttons to toggle the left and right sides of the controllers between decks. Signed-off-by: Sam Whited <[email protected]>
50bac15
to
ecd7731
Compare
Ok, if scripting is needed for functionality it's fine
Signed-off-by: Sam Whited <[email protected]>
Signed-off-by: Sam Whited <[email protected]>
Signed-off-by: Sam Whited <[email protected]>
Added a commit allowing the gain knob LED (for both the main gain and the decks) to be used as a peak indicator and a setting to enable/disable it and select the color of the indicator as well as a similar setting to use the tempo knob button as a beat indicator (this one is off by default to avoid flashing distractions, but could be used when beat syncing). |
128c1b7
to
4a563a6
Compare
Signed-off-by: Sam Whited <[email protected]>
4a563a6
to
d0946ae
Compare
Signed-off-by: Sam Whited <[email protected]>
6f92ebd
to
a3da78c
Compare
Signed-off-by: Sam Whited <[email protected]>
Signed-off-by: Sam Whited <[email protected]>
I've made a companion PR to document this controller here: mixxxdj/manual#747 |
Signed-off-by: Sam Whited <[email protected]>
Signed-off-by: Sam Whited <[email protected]>
This does not change any functionality by default except that the LED below each button automatically becomes an indicator letting you know the controller is centered.
It does, however, make the controller work with all 4 decks by rewriting it in ComponentsJS.
It lets you select independently which side of the controller is being used for what (as opposed to changing the entire controller between decks 1, 2 and 3, 4), so you could be making changes to decks 1 and 4 at the same time, for example.
This also paves the way for mapping the other layers (eg. to an effects controller) at a later date.
There is currently no manual page for this controller to update.