-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat(QML): add basic DnD Deck interface #14849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
afe82d9
to
bd2e88d
Compare
bd2e88d
to
afe82d9
Compare
afe82d9
to
dd94653
Compare
This PR is a little bit large as it adds all the basic deck component, but doesn't bring any new C++ code so hopefully won't be too hard to review! |
dd94653
to
0f2958a
Compare
0f2958a
to
dd94653
Compare
function trigger() { | ||
this.value = 1; | ||
this.value = 0; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a workaround. Isn't this a generic functionality, that should be implemented in Mixxx.ControlProxy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It isn't that straightforward unfortunately. The reason for implementing this at the QML level, is that we can leverage property binding so both update (1
then 0
) will correctly be reported to the CO slots, unconditionally of the event loop state. I believe this is what that pattern was implemented and is already used in other places.
No doubt that this is hacky tho, so perhaps I can create a follow up issue?
27311ce
to
789322e
Compare
Partially addresses #14523 and #14524. Serialisation of edited decks to come in #14539
Screencast.From.2025-05-26.03-52-57.mp4
Notes: