Skip to content

Conversation

acolombier
Copy link
Member

Partially addresses #14523 and #14524. Serialisation of edited decks to come in #14539

Screencast.From.2025-05-26.03-52-57.mp4

Notes:

  • The ability to remove elements from the deck will come in follow up PR. This will allow better experience on smaller screen
  • The bouncing animation won't be kept long term, but for now it help assessing the well functioning resizing/position

@acolombier acolombier added this to the 3.0-beta milestone May 31, 2025
@github-project-automation github-project-automation bot moved this to In progress in QML GUI May 31, 2025
@acolombier acolombier self-assigned this Jun 18, 2025
@github-actions github-actions bot added library ui code quality preferences waveform developer experience Issues, bugs and PRs related to the development process, development environment & developer docs labels Sep 15, 2025
@acolombier
Copy link
Member Author

This PR is a little bit large as it adds all the basic deck component, but doesn't bring any new C++ code so hopefully won't be too hard to review!

Comment on lines +49 to +52
function trigger() {
this.value = 1;
this.value = 0;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a workaround. Isn't this a generic functionality, that should be implemented in Mixxx.ControlProxy?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It isn't that straightforward unfortunately. The reason for implementing this at the QML level, is that we can leverage property binding so both update (1 then 0) will correctly be reported to the CO slots, unconditionally of the event loop state. I believe this is what that pattern was implemented and is already used in other places.
No doubt that this is hacky tho, so perhaps I can create a follow up issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build code quality developer experience Issues, bugs and PRs related to the development process, development environment & developer docs library needs review preferences qml scanner ui waveform
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

2 participants