Skip to content

Conversation

acolombier
Copy link
Member

Depends on #14514

void tracklistChanged();

protected slots:
void slotShowTrackModel(std::shared_ptr<QmlLibraryTrackListModel> pModel);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fx the Clazy warning

void slotShowTrackModel(QAbstractItemModel* pModel);

signals:
void requestTrackModel(std::shared_ptr<QmlLibraryTrackListModel> pModel);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the Clazy warning

QList<QmlPlaylistProxy*> QmlLibraryPlaylistSource::list() {
QList<QmlPlaylistProxy*> list;
auto& playlistDao = m_pLibraryFeature->dao();
for (const auto& [id, name] : playlistDao.getPlaylists(PlaylistDAO::PLHT_NOT_HIDDEN)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the Clazy warning

@acolombier
Copy link
Member Author

Thanks for the review @JoergAtGithub , but I'd like to to get #14514 to prevent conflicts. I'll update the PR state and label to reflect that

@acolombier acolombier force-pushed the feat/qml-library-more-features branch 2 times, most recently from 0b5f78d to 36ba24c Compare September 20, 2025 01:24
@acolombier acolombier marked this pull request as draft September 20, 2025 01:24
@acolombier
Copy link
Member Author

Quite broken after rebasing - putting back as draft till I get a chance to fix it!

@acolombier acolombier force-pushed the feat/qml-library-more-features branch from 36ba24c to bc00432 Compare September 20, 2025 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

2 participants