QML: Add basic playlist, crates and browser feature #14851
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/qml/qmlsidebarmodelproxy.h
Outdated
| void tracklistChanged(); | ||
|
|
||
| protected slots: | ||
| void slotShowTrackModel(std::shared_ptr<QmlLibraryTrackListModel> pModel); |
There was a problem hiding this comment.
Please fx the Clazy warning
| void slotShowTrackModel(QAbstractItemModel* pModel); | ||
|
|
||
| signals: | ||
| void requestTrackModel(std::shared_ptr<QmlLibraryTrackListModel> pModel); |
There was a problem hiding this comment.
Please fix the Clazy warning
| QList<QmlPlaylistProxy*> QmlLibraryPlaylistSource::list() { | ||
| QList<QmlPlaylistProxy*> list; | ||
| auto& playlistDao = m_pLibraryFeature->dao(); | ||
| for (const auto& [id, name] : playlistDao.getPlaylists(PlaylistDAO::PLHT_NOT_HIDDEN)) { |
There was a problem hiding this comment.
Please fix the Clazy warning
|
Thanks for the review @JoergAtGithub , but I'd like to to get #14514 to prevent conflicts. I'll update the PR state and label to reflect that |
acolombier
force-pushed
the
feat/qml-library-more-features
branch
2 times, most recently
from
0b5f78d to
36ba24c
Compare
|
Quite broken after rebasing - putting back as draft till I get a chance to fix it! |
acolombier
force-pushed
the
feat/qml-library-more-features
branch
from
36ba24c to
bc00432
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #14514