-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
QML: Add basic playlist, crates and browser feature #14851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
src/qml/qmlsidebarmodelproxy.h
Outdated
void tracklistChanged(); | ||
|
||
protected slots: | ||
void slotShowTrackModel(std::shared_ptr<QmlLibraryTrackListModel> pModel); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fx the Clazy warning
void slotShowTrackModel(QAbstractItemModel* pModel); | ||
|
||
signals: | ||
void requestTrackModel(std::shared_ptr<QmlLibraryTrackListModel> pModel); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the Clazy warning
QList<QmlPlaylistProxy*> QmlLibraryPlaylistSource::list() { | ||
QList<QmlPlaylistProxy*> list; | ||
auto& playlistDao = m_pLibraryFeature->dao(); | ||
for (const auto& [id, name] : playlistDao.getPlaylists(PlaylistDAO::PLHT_NOT_HIDDEN)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the Clazy warning
Thanks for the review @JoergAtGithub , but I'd like to to get #14514 to prevent conflicts. I'll update the PR state and label to reflect that |
0b5f78d
to
36ba24c
Compare
Quite broken after rebasing - putting back as draft till I get a chance to fix it! |
36ba24c
to
bc00432
Compare
Depends on #14514