Skip to content

Fix macOS build environment script #15354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix macOS build environment script #15354

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tools/macos_buildenv.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ fi

HOST_ARCH=$(uname -m) # One of x86_64, arm64, i386, ppc or ppc64

if [ "$HOST_ARCH" == "x86_64" ]; then
if [[ "$HOST_ARCH" == "x86_64" ]]; then
if [ -n "${BUILDENV_ARM64_CROSS}" ]; then
if [ -n "${BUILDENV_RELEASE}" ]; then
Comment on lines 33 to 34
Copy link
Preview

Copilot AI Sep 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] For consistency with the updated conditional checks, consider updating these remaining single bracket conditionals to use double brackets [[ ]] syntax as well.

Copilot uses AI. Check for mistakes.

VCPKG_TARGET_TRIPLET="arm64-osx-min1100-release"
Expand All @@ -55,7 +55,7 @@ if [ "$HOST_ARCH" == "x86_64" ]; then
BUILDENV_SHA256="0c75b39d6c03e34e794ab95cc460b1d11a0b976d572e31451b7c0798d9035d73"
fi
fi
elif [ "$HOST_ARCH" == "arm64" ]; then
elif [[ "$HOST_ARCH" == "arm64" ]]; then
if [ -n "${BUILDENV_RELEASE}" ]; then
Copy link
Preview

Copilot AI Sep 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] For consistency with the updated conditional checks, consider updating this remaining single bracket conditional to use double brackets [[ ]] syntax as well.

Suggested change
if [ -n "${BUILDENV_RELEASE}" ]; then
if [[ -n "${BUILDENV_RELEASE}" ]]; then

Copilot uses AI. Check for mistakes.

VCPKG_TARGET_TRIPLET="arm64-osx-min1100-release"
BUILDENV_BRANCH="2.6-rel"
Expand Down
Loading