(fix) Library Preferences: compose font style if font has no styleName() #15382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some fonts
font.styleName()is empty and the font display doesn't reflect the selected font.Eg. Open Sans Semibold 12pt would be shown as "Open Sans 12pt"
If the style string is empty, let's compose the style manually from
Weight weight()andbool italic().Now it's Open Sans Semibold Italic 12 pt
The tr strings used in QFontDialog are not available so I made that
tr().Though even untranslated that's better than nothing IMO
IIRC that has been reported but I don't find a matching issue. Maybe it was in the forums or on Zulip