Skip to content

Conversation

@ronso0
Copy link
Member

@ronso0 ronso0 commented Oct 10, 2025

followup for #15392

qss: adjust style in all skins
c++: also apply hover style

@ronso0 ronso0 added this to the 2.6.0 milestone Oct 16, 2025
@ronso0 ronso0 added the library label Oct 16, 2025
@daschuer
Copy link
Member

I can only confirm the hover style for Tango.
Only Tango uses the selected text for the sidebar and the headers.
All skins however use the text size selected along with the font.

Is this the desire behaviour?

@ronso0
Copy link
Member Author

ronso0 commented Oct 17, 2025

I can only confirm the hover style for Tango.

Correct, only Tango sets a hover style.

All skins however use the text size selected along with the font.

Yup, as explained in #15392, IMO the column buttons are controls, not content, and should therefore uss the font the skin designer picked.

@ronso0
Copy link
Member Author

ronso0 commented Oct 17, 2025

So, ready for merge?

@daschuer
Copy link
Member

Yup, as explained in #15392, IMO the column buttons are controls, not content, and should therefore use the font the skin designer picked.

Except for Tango? Or is this a remaining issue?

I have no strong opinion here, but does this size decision than also belongs to the skin designer?

A full blows feature would be to have an option "[ ] override skin font + size" if only if that is checked the user can adjust it and than use it for sidebar and header as well.

@ronso0
Copy link
Member Author

ronso0 commented Oct 18, 2025

Except for Tango? Or is this a remaining issue?

Oh, that slipped through indeed. Fixed.

@ronso0
Copy link
Member Author

ronso0 commented Oct 18, 2025

I have no strong opinion here, but does this size decision than also belongs to the skin designer?

Hmm no IMO. The point of customizing the library font & size is to allow more content or adjust size to be readable from a distance (or compensate for visual impairment). So for this, the user is the designer.

@ronso0
Copy link
Member Author

ronso0 commented Oct 18, 2025

A full blows feature would be to have an option "[ ] override skin font + size" if only if that is checked the user can adjust it and than use it for sidebar and header as well.

To clarify, and quote the lengthy description of #15392:

Though QStylesheetStyle seems to be quite dominant/persistant: setFont() only adopts font properties which we did NOT set in qss. Ie. it does NOT override qss styles.

= we can't pre-set a font in qss and then override it in c++ with setFont().
(note I didn't try do it via setStyleSheet("WTrackTableViewHeader { font: .. }.)

@ronso0
Copy link
Member Author

ronso0 commented Oct 28, 2025

friendly ping
Let's get this fixup in.

@daschuer
Copy link
Member

Deere: Tree font does not adopt the library font, only the size. Feels wrong.

@ronso0
Copy link
Member Author

ronso0 commented Oct 29, 2025

Sorry, I didn't check Deere thoroughly enough.
Fixed, searchbar was also affected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants