-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
(fix) Header fixup #15476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.6
Are you sure you want to change the base?
(fix) Header fixup #15476
Conversation
|
I can only confirm the hover style for Tango. Is this the desire behaviour? |
Correct, only Tango sets a hover style.
Yup, as explained in #15392, IMO the column buttons are controls, not content, and should therefore uss the font the skin designer picked. |
|
So, ready for merge? |
Except for Tango? Or is this a remaining issue? I have no strong opinion here, but does this size decision than also belongs to the skin designer? A full blows feature would be to have an option "[ ] override skin font + size" if only if that is checked the user can adjust it and than use it for sidebar and header as well. |
Oh, that slipped through indeed. Fixed. |
Hmm no IMO. The point of customizing the library font & size is to allow more content or adjust size to be readable from a distance (or compensate for visual impairment). So for this, the user is the designer. |
To clarify, and quote the lengthy description of #15392:
= we can't pre-set a font in qss and then override it in c++ with |
|
friendly ping |
|
Deere: Tree font does not adopt the library font, only the size. Feels wrong. |
|
Sorry, I didn't check Deere thoroughly enough. |
followup for #15392
qss: adjust style in all skins
c++: also apply hover style