library: display hotcues on overview waveform #15514

mxmilkiib · 2025-10-20T04:16:34Z

displays hotcue markers and minute markers on library overview waveform column, similar to rekordbox.

changes:

hotcue markers: 10px wide bright vertical lines at each hotcue position
minute markers: white vertical ticks at top and bottom every 60 seconds
rendering: markers drawn after waveform normalization for maximum visibility
colors: uses smart contrast colors, 60% brighter for visibility

implementation:

modified waveformOverviewRenderer::render() to accept hotcue data and track duration
extended OverviewCache::prepareOverview() to load cues via CueDAO and track metadata
added HotcueInfo struct to pass cue position, color, and label to renderer
disabled smooth pixmap transform in delegate to preserve marker opacity

- add hotcue marker rendering in library overview waveform column - load cue data and track metadata (duration, sample rate) in OverviewCache::prepareOverview() - draw hotcue markers as semi-transparent vertical lines with cue colors - calculate hotcue positions proportionally across waveform width based on track duration implements mixxxdj#14994

ronso0 · 2025-10-20T13:19:46Z

src/waveform/renderers/waveformoverviewrenderer.cpp

+                markerPainter.setCompositionMode(QPainter::CompositionMode_SourceOver);
+            }
+        }
+    }


Can you explain why we need to set the CompositionMode?
And why you picked 10px (!) for a position marker?

Also note that both the waveforms and the overview draw wider, contrasting "shadow" lines underneath the actual marker lines to increase visibility (colors set here, shadow lines set here

Is there a need for the intermediate baseColor?

I tried a few ways to get the lines to be as distinct as on the deck overview but struggled

10px made it almost bearable

I'll see what I can do now

and no

I tried a few ways to get the lines to be as distinct as on the deck overview but struggled

Okay, that's because this paints the full-width waveform and the scaling to desired width happens in OverviewCache (IIRC this has been adopted from CoverArtCache), hence no fixed width here will guarantee that the markers have adequate width in the final image in the library.

Options are a) pass the resized image here (to a new function) to paint the hotcue overlay, b) do the scaling here and paint hotcues on top, or c) ...

Back'n forth of a) is not ideal (heayv QImage), so it's b) unless you/ai figure another way.

btw, please remove those // MARK: .. comments, IMO they're pointless

ronso0 · 2025-10-20T13:34:21Z

src/library/overviewcache.cpp

+            QSqlQuery query(database);
+            query.prepare(QStringLiteral("SELECT " LIBRARY_TABLE ".") +
+                    LIBRARYTABLE_DURATION + QStringLiteral(", " LIBRARY_TABLE ".") +
+                    LIBRARYTABLE_SAMPLERATE +
+                    QStringLiteral(" FROM " LIBRARY_TABLE " WHERE " LIBRARY_TABLE ".id=:id"));
+            query.bindValue(":id", trackId.toVariant());
+            if (query.exec() && query.next()) {
+                trackDurationMillis = query.value(0).toDouble() *
+                        1000.0; // convert seconds to milliseconds
+                sampleRate = query.value(1).toInt();
+                if (sampleRate <= 0) {
+                    sampleRate = 44100; // fallback if invalid
+                }
+            }


Instead of doing SQL queries here we may get values from columns in the delegate?
If possible I'd prefer that instead of acting on the db here.

✅ completely removed database queries from prepareOverview()
✅ now passes TrackPointer from delegate
✅ gets cues via pTrack->getCueInfos() and duration via pTrack->getDuration()

ronso0 · 2025-10-20T13:35:20Z

src/waveform/renderers/waveformoverviewrenderer.cpp

+                        2,
+                        imageHeight - lowerMarkerYPos,
+                        minuteColor);
+                markerPainter.setCompositionMode(QPainter::CompositionMode_SourceOver);


Why set/reset the CompositionMode for each marker?
Consider using PainterScope.

✅ now using PainterScope instead of manual setCompositionMode() calls

ronso0 · 2025-10-20T13:35:51Z

src/waveform/renderers/waveformoverviewrenderer.cpp

+        // draw hotcue markers
+        if (!hotcues.isEmpty()) {
+            for (const auto& hotcue : hotcues) {
+                if (hotcue.positionMillis <= 0 || hotcue.positionMillis > trackDurationMillis) {


Why skip hotcues in the preroll?

✅ now allows negative positions (removed positionMillis <= 0 check)
✅ only skips hotcues beyond track end

ronso0 · 2025-10-20T13:38:34Z

src/waveform/renderers/waveformoverviewrenderer.h

+struct HotcueInfo {
+    double positionMillis;
+    mixxx::RgbColor::code_t colorCode;
+    QString label;
+};


Why do we need a struct if we already have the CueInfo class?

✅ removed custom struct
✅ now uses existing mixxx::CueInfo class directly
✅ filters by CueType::HotCue in renderer

- use existing CueInfo instead of custom HotcueInfo struct - pass track metadata from delegate instead of SQL queries in OverviewCache - use PainterScope for hotcue rendering - match deck overview marker style: 1px border + 1px fill line - allow preroll hotcues (negative positions) - remove unnecessary intermediate variables

Track does not have a getCueInfos() method - need to iterate through getCuePoints() and call getCueInfo(sampleRate) on each cue

github-actions bot added library waveform labels Oct 20, 2025

mxmilkiib force-pushed the feature/hotcues-on-overview-waveform branch from 9323387 to 4f2aace Compare October 20, 2025 05:46

ronso0 reviewed Oct 20, 2025

View reviewed changes

Milkii Brewster added 2 commits October 20, 2025 23:31

fix: convert cue points to cue infos using getCueInfo()

7a85743

Track does not have a getCueInfos() method - need to iterate through getCuePoints() and call getCueInfo(sampleRate) on each cue

Uh oh!

library: display hotcues on overview waveform #15514

Are you sure you want to change the base?

library: display hotcues on overview waveform #15514

Uh oh!

Conversation

mxmilkiib commented Oct 20, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ronso0 Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ronso0 Oct 20, 2025 •

edited

Loading