Fix quantisation of the effects in case of engine samplerate != track samplerate #15538
+30
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Changes look reasonable, though I'm not confident enough to give LGTM |
Swiftb0y
reviewed
Nov 6, 2025
Member
Swiftb0y
left a comment
Swiftb0y
left a comment
There was a problem hiding this comment.
FX code LGTM. I just don't quite understand the enginebuffer code change
| } | ||
|
|
||
| m_actual_speed = (m_playPos - playpos_old) / (iBufferSize / 2); | ||
| m_actual_speed = (m_playPos - playpos_old) / (iBufferSize / 2) / baseSampleRate; |
Member
There was a problem hiding this comment.
whats the purpose of baseSampleRate?
Member
Author
There was a problem hiding this comment.
baseSampleRate is a ratio. It normalizes the value form track to engine sample rate.
Swiftb0y
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #15300
Now the beat length is reported in seconds, to avoid any samplerate related misunderstandings.