Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Don't merge] libshout idjc 2.4.6 #4723

Draft
wants to merge 15 commits into
base: 2.5
Choose a base branch
from
Draft

[Don't merge] libshout idjc 2.4.6 #4723

wants to merge 15 commits into from

Conversation

daschuer
Copy link
Member

This is an experimental branch to update to the recent libshout idjc.
Currently we have a patched libshout idjc 2.4.1 in our lib folder which works without known issues.
Once the libshout idjc 2.4.6 will land to Linux distros our build system will link against that and we can later remove our vendored version. This PR can used to do some preliminary checks.
If we need features form the new 2.4.6 version before, we may consider to merge this.

@daschuer daschuer marked this pull request as draft April 12, 2022 08:08
@daschuer daschuer force-pushed the libshout-idjc-2.4.6 branch from d86079c to 62b57cc Compare April 12, 2022 08:44
@github-actions github-actions bot added the build label Apr 12, 2022
@daschuer daschuer force-pushed the libshout-idjc-2.4.6 branch 3 times, most recently from 02c4ff6 to ac35179 Compare April 12, 2022 11:01
@daschuer daschuer mentioned this pull request May 3, 2022
Merged
@github-actions
Copy link

This PR is marked as stale because it has been open 90 days with no activity.

@github-actions github-actions bot added the stale Stale issues that haven't been updated for a long time. label Jul 12, 2022
@ronso0
Copy link
Member

ronso0 commented Sep 12, 2022 •
edited
Loading

2.4.6 is in Kinetic kudo, while 22.04 Jammy Jellyfish LTS has 2.4.5.
https://packages.ubuntu.com/search?searchon=sourcenames&keywords=libshout
So why not use 2.4.5?

@daschuer
Copy link
Member Author

So why not use 2.4.5?
2.4.5. suffers: #10305

We use libshout-idjc, not plain libshout

Jammy: 2.4.3-1 https://packages.ubuntu.com/jammy/libshout-idjc3
Kinetic: 2.4.4-1 https://packages.ubuntu.com/kinetic/libshout-idjc3

Do we have an issue with our current situation?

@ronso0
Copy link
Member

ronso0 commented Sep 12, 2022

We use libshout-idjc, not plain libshout

yeah, my bad 🙄
I'm not aware of any specific issues, or rather I didn't bother to check whether the frequent broadcast issues being reported on the forums are related to libshout-idjc.

@github-actions github-actions bot removed the stale Stale issues that haven't been updated for a long time. label Sep 13, 2022
@daschuer daschuer force-pushed the libshout-idjc-2.4.6 branch from 52bc568 to e2a5fe8 Compare October 5, 2023 06:42
@github-actions github-actions bot removed the build label Oct 5, 2023
@daschuer daschuer force-pushed the libshout-idjc-2.4.6 branch from e2a5fe8 to ce2f5ac Compare October 8, 2023 16:42
@github-actions github-actions bot added the build label Oct 8, 2023
@daschuer daschuer force-pushed the libshout-idjc-2.4.6 branch from ce2f5ac to dbcb59e Compare October 8, 2023 19:45
@daschuer daschuer force-pushed the libshout-idjc-2.4.6 branch from dbcb59e to f987932 Compare October 8, 2023 19:46
@daschuer daschuer changed the base branch from main to 2.4 October 8, 2023 19:47
@github-actions github-actions bot added the build label Oct 10, 2023
@daschuer daschuer force-pushed the libshout-idjc-2.4.6 branch from d29e0cc to be320a9 Compare October 10, 2023 20:54
@github-actions GitHub Actions
Copy link

This PR is marked as stale because it has been open 90 days with no activity.

@github-actions github-actions bot added the stale Stale issues that haven't been updated for a long time. label Jan 14, 2024
@daschuer daschuer mentioned this pull request Mar 31, 2024
Open
@acolombier acolombier mentioned this pull request May 25, 2024
Open
@daschuer daschuer changed the base branch from 2.4 to 2.5 January 4, 2025 16:58
@daschuer
Copy link
Member Author

daschuer commented Jan 4, 2025

Ubuntu Oracular will have 2.4.6-2: https://packages.ubuntu.com/oracular/libshout-idjc3
I have rebased this on the current 2.5 branch to have new testing builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
broadcast Bugs pertaining to streaming radio broadcaster use-case
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daschuer @ronso0