-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add parent attribute (#71) #206
Conversation
I'm hopefully choosing the simplest solution for introducing this feature. By making both the An alternative approach would possibly be to pass the Another thing is the performance penalty - running the benchmark ( All in all, if someone (like @anderskaplan? ;)) doesn't propose a better solution, I would finish this PR (adding some docs and updating the benchmark results (yes, we should automate running those benchmarks...)) and merge it to the master branch. I think this would nicely complement the recent PR #188... |
7e7bb78
to
2148c33
Compare
At the same time, we also make the `children` attribute a _property_. This makes it easier for us to set the `parent` to every child token, without having to change much of the existing code.
2148c33
to
6744856
Compare
I've decided to merge this into the master and update the benchmark results later on (there is more to update). Here are the COMPATIBILITY REMARKS:
|
Hey, sorry for not coming back to this. But since this has been merged, then I guess we can close my PR #72? :) |
@vallentin, you are right, thanks for the reminder. 👍 |
This resolves #71 and is a continuation / replacement for PR #72.