Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix constant used in rejection sampling when accumulate_weights=True #365

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

mj-will
Copy link
Owner

@mj-will mj-will commented Jan 26, 2024

No description provided.

@mj-will mj-will added the bug Something isn't working label Jan 26, 2024
@mj-will mj-will added this to the v0.12.0 milestone Jan 26, 2024
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d385b09) 93.28% compared to head (722bc28) 93.28%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #365   +/-   ##
=======================================
  Coverage   93.28%   93.28%           
=======================================
  Files          67       67           
  Lines        6361     6363    +2     
=======================================
+ Hits         5934     5936    +2     
  Misses        427      427           
Flag Coverage Δ
unittests 93.28% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mj-will mj-will merged commit 050f0fd into main Jan 26, 2024
30 checks passed
@mj-will mj-will deleted the fix-constant-accumulate-weights branch January 26, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant