Skip to content

MAINT: logging tweaks#445

Merged
mj-will merged 12 commits intomainfrom
logger-tweaks
Dec 20, 2024
Merged

MAINT: logging tweaks#445
mj-will merged 12 commits intomainfrom
logger-tweaks

Conversation

@mj-will
Copy link
Copy Markdown
Owner

@mj-will mj-will commented Dec 20, 2024

This PR renames setup_logger to configure_logger (the verb is set up not setup) and adds a new argument, include_logger_name.

include_logger_name

If true, the name of the logger is included in the output, e.g. nessai.livepoint, if false, then this is replaced with nessai. I've set the default to False since I think the information isn't useful to most users.

@mj-will mj-will added the enhancement New feature or request label Dec 20, 2024
@mj-will mj-will added this to the v0.14.0 milestone Dec 20, 2024
@mj-will mj-will merged commit 1ff98a9 into main Dec 20, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.89%. Comparing base (e3375e8) to head (9b1aaba).
Report is 66 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #445   +/-   ##
=======================================
  Coverage   93.88%   93.89%           
=======================================
  Files          72       72           
  Lines        7020     7027    +7     
=======================================
+ Hits         6591     6598    +7     
  Misses        429      429           
Flag Coverage Δ
unittests 93.66% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mj-will mj-will mentioned this pull request Jan 9, 2025
@mj-will mj-will deleted the logger-tweaks branch February 4, 2025 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant