Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: add importlib-metadata dependency for python < 3.10 #450

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

mj-will
Copy link
Owner

@mj-will mj-will commented Jan 10, 2025

When adding support for entry points, I forgot to add importlib-metadata as an explicit dependency for Python < 3.10.
This PR adds that dependency.

Once this is merged, I'll backport this to v0.14.0 and make a post-release.

@mj-will mj-will added the build Related to building and distributing nessai label Jan 10, 2025
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.89%. Comparing base (17db788) to head (5da3e50).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #450   +/-   ##
=======================================
  Coverage   93.89%   93.89%           
=======================================
  Files          72       72           
  Lines        7027     7027           
=======================================
  Hits         6598     6598           
  Misses        429      429           
Flag Coverage Δ
unittests 93.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mj-will mj-will merged commit e9ea69b into main Jan 10, 2025
29 checks passed
@mj-will mj-will deleted the add-importlib-metadata-dependency branch January 10, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to building and distributing nessai
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant