Add long-lived worker sessions and typed protocol - #10
Draft
mjc wants to merge 16 commits into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack 4 of 13. Depends on
02-cli-domain-hardening.This introduces the long-lived WebSocket worker loop, reconnect backoff, typed Phoenix protocol messages, job assignment and result flow, protocol rejection handling, tracing, and an isolated worker-job execution path.
A worker can now join, announce capabilities, pull work repeatedly, recover connections, run CRF searches, and publish structured results without weakening the existing CLI and ffmpeg argument contracts.
Tests added in this branch run a WebSocket harness through join, announce, no-work polling, assignment, cancellation, disconnect/reconnect, protocol mismatch, and CRF completion. Protocol tests cover current and future payload shapes, structured results and failures, heartbeat metadata, isolated job paths, transfer framing validation, corrupt/duplicate/out-of-order chunks, size limits, resume behavior, and refusal to overwrite destinations.