Transfer worker inputs over the socket - #11
Draft
mjc wants to merge 7 commits into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack 5 of 13. Depends on
03-worker-session-protocol.This wires Phoenix binary frames into resumable worker input transfers, adds input-resend state, keeps the socket alive while jobs run, and publishes CRF and transfer progress with job identity and throughput.
Workers can receive remote inputs over the existing channel, recover a missing resumed input, and report enough phase/progress metadata for the coordinator to distinguish transfer, search, and failure states.
Tests added in this branch prove Phoenix-enveloped binary chunks decode correctly, malformed framing is rejected, resumed transfers request missing input, pull-work payloads describe local-input availability, CRF progress/result events match the coordinator contract, transfer rates and metadata serialize correctly, and worker phases choose the right local or transferred input path.