Make multiplexed jobs independently controllable - #15
Draft
mjc wants to merge 13 commits into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack 9 of 13. Depends on
07-multiplexed-encode.This gives multiplexed jobs independent process scopes and control state, preserves active outputs during CRF cleanup, fans worker-wide controls out to jobs, replays active jobs after reconnect, supports concurrency overrides, and retains encode jobs until completion acknowledgement.
Controls can now target one job or the whole worker without signaling unrelated processes. Finished outputs and local inputs remain owned until the coordinator has acknowledged the terminal event.
Tests added in this branch prove scoped process groups isolate pause/stop signals, targeted and unscoped controls select the intended jobs, active control state and jobs replay after reconnect, output/input cleanup waits for success and acknowledgement, heartbeats continue without ffmpeg timestamps, transfer ETA handles zero/nonzero rates, concurrency overrides capacity, and pull errors request reconnect.