Skip to content

Make worker controls and completion durable - #16

Draft
mjc wants to merge 13 commits into
mjc/abav1-214-stack-08-multiplexed-control-reconnectfrom
mjc/abav1-214-stack-09-worker-durability-acknowledgements
Draft

Make worker controls and completion durable#16
mjc wants to merge 13 commits into
mjc/abav1-214-stack-08-multiplexed-control-reconnectfrom
mjc/abav1-214-stack-09-worker-durability-acknowledgements

Conversation

@mjc

@mjc mjc commented Aug 10, 2026

Copy link
Copy Markdown
Owner

Stack 10 of 13. Depends on 08-multiplexed-control-reconnect.

This makes job controls durable across reconnects, acknowledges control application, cleans failed/stopped job artifacts, propagates child exit status, preserves nested CRF failures, expires abandoned offline jobs, and requires acknowledgements for every terminal worker outcome.

Pause and stop now cover input transfer, probing, execution, and output upload rather than only active encoders. Reconnect attempts cancel stale work, while acknowledged terminal identity prevents duplicate or premature cleanup.

Tests added in this branch exercise pause/resume/stop during socket input, HTTP input, probing, execution, and HTTP output; replay after lost completion acknowledgement; active-attempt cancellation; offline lease expiry and owned-file cleanup; child exit-code mapping; nested process failure propagation; reconnect control retention; and exhaustive terminal-event acknowledgement identity.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 80b91068-ae3d-4dd1-9db7-b2dd2ed32957

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant