Make worker controls and completion durable - #16
Draft
mjc wants to merge 13 commits into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack 10 of 13. Depends on
08-multiplexed-control-reconnect.This makes job controls durable across reconnects, acknowledges control application, cleans failed/stopped job artifacts, propagates child exit status, preserves nested CRF failures, expires abandoned offline jobs, and requires acknowledgements for every terminal worker outcome.
Pause and stop now cover input transfer, probing, execution, and output upload rather than only active encoders. Reconnect attempts cancel stale work, while acknowledged terminal identity prevents duplicate or premature cleanup.
Tests added in this branch exercise pause/resume/stop during socket input, HTTP input, probing, execution, and HTTP output; replay after lost completion acknowledgement; active-attempt cancellation; offline lease expiry and owned-file cleanup; child exit-code mapping; nested process failure propagation; reconnect control retention; and exhaustive terminal-event acknowledgement identity.