Harden worker reconnects and runtime reporting - #18
Draft
mjc wants to merge 7 commits into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack 12 of 13. Depends on
10-weighted-crf-scheduling.This preserves complete command stdout, moves worker-owned data to the system temp directory, reconnects dead Phoenix channels, normalizes every connection-loss path, discards stale reconnect attempts, reports temp-filesystem capacity, and returns typed CRF failure reasons.
Long-running workers now treat socket closure, channel errors, pull errors, and acknowledgement deadlines consistently. Capacity reporting reflects the filesystem actually used for worker data, and failed CRF searches explain why no candidate was acceptable.
Tests added in this branch cover complete stdout with bounded stderr, system-temp input placement, normalized disconnect frames, channel and pull reconnect decisions, acknowledgement liveness deadlines, stale reconnect handling, filesystem capacity payloads, and structured no-acceptable-CRF reporting including the oversized adjacent candidate.