Skip to content

Conversation

@jhollowe
Copy link

Adds the ability for VS Code workspace to be a symbolic link to a Perforce workspace by following any symlinks in the VS Code workspace path.

Adds the ability for VS Code workspace to be a symbolic link to a Perforce workspace by following any symlinks in the VS Code workspace path.
@mjcrouch
Copy link
Owner

mjcrouch commented Apr 28, 2022

Thanks for raising - I can see I need to fix the pipelines!

I'm not in a great position to try this out fully - Wondering what combinations you have tested?

For example is it possible that p4 info might itself return a symlink in the "Client root" field? (I don't know the answer, but it seems likely if you specified your client root as a symlink then p4 info would return that symlink back to you)

In which case, by only following the real path we might break previously working cases where both the client root and the workspace are both symlinks.

detect a URI as being in the perforce workspace with a normal or symbolic link path.
@jhollowe
Copy link
Author

This allows the extension to know the files are in the perforce workspace, but it seems perforce automatically expands the symlinks, so commands (i.e. p4 opened) show the symlinks as not being in the perforce workspace; I need to work on it more to ensure everything works with a symlink client root.

@jhollowe
Copy link
Author

jhollowe commented May 2, 2022

I don't have time to get everything working with the symlink workspace right now, but I believe the current code will not hurt anything, just give a partial solution which myself or others can expand on later.

@jolopezl
Copy link

I just created an issue regarding this: #298. This pull request is quite old. Can we still expect some activity, or is help required for testing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants