Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add $CURSOR for position in zsh.sh script #24

Merged
merged 1 commit into from
May 30, 2016

Conversation

binduwavell
Copy link
Collaborator

fixes #23

@mklabs
Copy link
Owner

mklabs commented May 30, 2016

Great! Could you update the test as well ? https://github.com/mklabs/node-tabtab/blob/master/test/complete.js#L19

We should probably add a bunch more to cover all possible cases you described in #25

I still need to improve the tests a lot more. I'd like to be able to programmatically trigger a tab completion but not sure how to do it, for now, we'll just tests stdout result.

@binduwavell
Copy link
Collaborator Author

You're existing tests pass and I only made zsh behave the same as bash, so I assumed for this commit I didn't have to write extra tests.

@mklabs
Copy link
Owner

mklabs commented May 30, 2016

oh, that's true :) Merging in this case.

Though I need to cover zsh too.

@mklabs mklabs merged commit 333d3eb into mklabs:master May 30, 2016
@mklabs
Copy link
Owner

mklabs commented May 30, 2016

Thanks again!

@binduwavell binduwavell deleted the feature-zsh-script branch May 31, 2016 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zsh.sh does not set cursor point/position (is always 0)
2 participants