Include port in X-Forwarded-Host header if not default#124
Open
jwgmeligmeyling wants to merge 1 commit intomkopylec:masterfrom
Open
Include port in X-Forwarded-Host header if not default#124jwgmeligmeyling wants to merge 1 commit intomkopylec:masterfrom
jwgmeligmeyling wants to merge 1 commit intomkopylec:masterfrom
Conversation
c8e2bbd to
fae1a4b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #124 +/- ##
=========================================
Coverage 90.80% 90.81%
Complexity 542 542
=========================================
Files 167 167
Lines 1849 1851 +2
Branches 54 55 +1
=========================================
+ Hits 1679 1681 +2
Misses 148 148
Partials 22 22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sgmeligmeyling
approved these changes
May 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #122.
After looking into it a bit better the resources are quite contradicting each other on whether the port should be in the header or not.
Perhaps we could at least make the behaviour configurable to support both flavors?