Skip to content

Include port in X-Forwarded-Host header if not default#124

Open
jwgmeligmeyling wants to merge 1 commit intomkopylec:masterfrom
jwgmeligmeyling:issue-122
Open

Include port in X-Forwarded-Host header if not default#124
jwgmeligmeyling wants to merge 1 commit intomkopylec:masterfrom
jwgmeligmeyling:issue-122

Conversation

@jwgmeligmeyling
Copy link
Copy Markdown

@jwgmeligmeyling jwgmeligmeyling commented May 28, 2021

Fixes #122.

After looking into it a bit better the resources are quite contradicting each other on whether the port should be in the header or not.

Perhaps we could at least make the behaviour configurable to support both flavors?

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 28, 2021

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.81%. Comparing base (f6311c9) to head (fae1a4b).
⚠️ Report is 35 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #124   +/-   ##
=========================================
  Coverage     90.80%   90.81%           
  Complexity      542      542           
=========================================
  Files           167      167           
  Lines          1849     1851    +2     
  Branches         54       55    +1     
=========================================
+ Hits           1679     1681    +2     
  Misses          148      148           
  Partials         22       22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Include port in X-Forwarded-Host header if its not the standard port for the scheme

3 participants