Skip to content

Commit

Permalink
Added wordpiece todo
Browse files Browse the repository at this point in the history
  • Loading branch information
mkranzlein committed Aug 22, 2023
1 parent 91f8518 commit 0b35e81
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ def some_function(x: Float[torch.Tensor, "10, 768"]):
I recommend taking a look at the [jaxtyping docs](https://docs.kidger.site/jaxtyping/).

## TODOs
- Eval needs to account for wordpiece splits
- Some long documents are too big for GPU vram right now
- Batching right now should allow for single documents, but worth testing
- Chunking logic could be more clear
Expand Down

0 comments on commit 0b35e81

Please sign in to comment.