optionally load metallib from framework #2702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidkoski
commented
Oct 24, 2025
| return nullptr; | ||
| } | ||
|
|
||
| MTL::Library* try_load_framework( |
There was a problem hiding this comment.
The logic in try_load_bundle isn't appropriate for a framework -- they have a different layout.
davidkoski
added a commit
to ml-explore/mlx-swift
that referenced
this pull request
Oct 24, 2025
davidkoski
added a commit
to ml-explore/mlx-swift
that referenced
this pull request
Oct 24, 2025
tests passing with ml-explore/mlx#2702 locally applied
davidkoski
added a commit
to ml-explore/mlx-swift
that referenced
this pull request
Oct 24, 2025
tests passing with ml-explore/mlx#2702 locally applied
davidkoski
added a commit
to ml-explore/mlx-swift
that referenced
this pull request
Oct 24, 2025
tests passing with ml-explore/mlx#2702 locally applied expose C++ API
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Support for ml-explore/mlx-swift#289 -- this will also allow
SWIFTPM_BUNDLEto name a framework identifier.Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes