Extract opentelemetry ID retrieval code into a macro #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `with_opentelemetry_ids` method contained repetitive code for handling different versions of the `tracing-opentelemetry` crate. This commit extracts the common logic into a macro called `otel_extraction`. The macro takes the feature name, the `OtelData` type, and the `opentelemetry` trace package path as arguments, and generates the necessary code to extract the trace and span IDs. This refactoring improves code maintainability and reduces duplication.
This commit refactors the `otel_extraction` macro to accept crate identifiers directly, rather than full paths to types. This simplifies the macro invocations and makes the code cleaner and easier to read. The macro now constructs the necessary paths to `OtelData` and `trace` internally. This change improves the developer experience when adding support for new OpenTelemetry versions.
mladedav
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jules PR