Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Django 3.0 #80

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Upgrade to Django 3.0 #80

wants to merge 9 commits into from

Conversation

juliorkm
Copy link

django-all-access unfortunately only supports Django 1. Many projects have difficulty upgrading to newer Django versions due to this dependency. This pull request makes this project work on Django 3.0, but due to Django's lack of backward compatibility, removes the ability to use it on earlier versions.

@mlavin
Copy link
Owner

mlavin commented Feb 20, 2020

I appreciate this effort and it would be great to see this project working on the latest Django (though as you can probably tell I don't really use this very much anymore). But I can't justify merging this while the test suite is broken.

@juliorkm juliorkm force-pushed the master branch 7 times, most recently from de0dde7 to 55e6d2d Compare March 2, 2020 20:12
@juliorkm
Copy link
Author

juliorkm commented Mar 2, 2020

My apologies, I had already fixed the tests for the most recent Django version, but hadn't updated the tox and travis configuration files. The test suite is now fixed.

@@ -13,31 +13,29 @@ def read_file(filename):


setup(
name='django-all-access',
name='django3-all-access',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are obviously welcome to publish your own version of this package under the terms of the BSD license but that shouldn't be part of this PR.

@bjinwright
Copy link

For those coming to this later. The new project from @juliorkm is
https://github.com/stormers/django-all-access. Mark @mlavin thanks for releasing the project and I hope you're doing well buddy.

@mlavin
Copy link
Owner

mlavin commented May 22, 2020

Brian! I'm doing well (all things considered). Sadly I don't really use Django much anymore, in case that wasn't already obvious from my inactivity here. If @juliorkm or you want to take over this project I'm happy to get you access to the PyPi repository and Read the Docs ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants