-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Automatic) version bump #831
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
priyakasimbeg
previously approved these changes
Feb 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Frank!
The merge-base changed after approval.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #830.
This PR matches the package version to our latest GitHub release version (https://github.com/mlcommons/algorithmic-efficiency/releases/tag/algoperf-benchmark-0.1.5).
Instead of manually defining the package version, it is now automatically determined by
setuptools_scm
via the latest GitHub tag. We don't have to do anything manually to increment the version in the future, just create the GitHub release/tag.The
CONTRIBUTING.md
file provides more details:Versioning Scheme Choice
The default setting of
setuptools_scm
automatically increments the version for commits after the latest tag. E.g. currently we are on(i.e. the future 0.1.6 release, with 210 commits from the latest commit and the current commit called
bad76f55
).An alternative versioning scheme would use the latest release version as the start, and report it as modifications to this tag, i.e.
Although I initially found the latter to be more intuitive, it probably makes more sense to stick to the default (i.e. the former). This is what is implemented in this PR, but if there are strong opinions, I am happy to change it.