-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix is_cpu_op bug #159
base: main
Are you sure you want to change the base?
fix is_cpu_op bug #159
Conversation
MLCommons CLA bot: |
Thanks for your contribution, @yue2388253. We acknowledge this problem and would like to merge this in, once you sign the CLA form (https://drive.google.com/file/d/1SkpAdb3ka8tXepCawgGxAyo6cUH5ZAZg/view). Could you please do so? |
Hi @willjwon, I have submitted the CLA form as requested. Could you kindly review and confirm if the PR is ready for merging? Thank you for your time and consideration. |
@yue2388253 Hi, sorry for super late reply for you. May I ask your email that you've used to register? |
Just checked you are formally with the CLA @yue2388253 ! |
Summary
Converting ASTRA-sim 1.0 text input files does not add
is_cpu_op
field. As a result, the COMM nodes are always skipped by the workload layer of astra-sim, as reported in #144 and astra-sim/astra-sim#224.Simply adding the attribute might fix the bug.