Implement KSM to pull a PAT for commits in format.yml #2011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
arjunsuresh
approved these changes
Jan 2, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the format.yml workflow to use a PAT to make automated commits rather than a SSH key. The SSH key method is specifically designed for making commits that bypass branch protections. The format.yml workflow does not need to bypass branch protections and instead needs a PAT to address the fact that the implicitly invoked
GITHUB_TOKENwill not trigger other workflow runs, namely the CLA-bot, as seen in this open PR.The modified version of format.yml in this PR uses Keeper Secrets Manager (KSM) to pull the
mlcommons-botPAT from Keeper. Our Keeper infrastructure handles the centralized management of keys, including automatic re-rolling of keys on demand and at regular intervals.