[fix] Add note about docker images to be pushed to Synapse#522
Closed
vpchung wants to merge 2 commits intomlcommons:mainfrom
vpchung:fix-mlcube-docs
Closed
[fix] Add note about docker images to be pushed to Synapse#522vpchung wants to merge 2 commits intomlcommons:mainfrom vpchung:fix-mlcube-docs
vpchung wants to merge 2 commits intomlcommons:mainfrom
vpchung:fix-mlcube-docs
Conversation
vpchung
had a problem deploying
to
testing-external-code
GitHub Actions
Failure
Contributor
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
vpchung
temporarily deployed
to
testing-external-code
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
A trending issue we came across in the BraTS 2023 challenge was that the config file did not contain the correct Docker image name, and so, I was not able to run some MLCubes in a timely manner. To help alleviate this issue for BraTS 2024 and future Synapse-hosted challenges utilizing MedPerf/MLCubes, I suggest a note is added to the docs about the naming expectations for
docker_image_namefor MLCubes to be submitted on Synapse.Feel free to expand and/or update the added note as you see fit.
Thanks!