Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CUDA_VISIBLE_DEVICES environment variable when using the --gpus flag #345

Merged
merged 8 commits into from
Jan 5, 2024

Conversation

davidjurado
Copy link
Contributor

@davidjurado davidjurado commented Nov 15, 2023

Solves issue 334

Install and try using:

virtualenv -p python3 env && source ./env/bin/activate

git clone https://github.com/mlcommons/mlcube && cd ./mlcube

git fetch origin pull/345/head:feature/docker_gpu && git checkout feature/docker_gpu

pip install -r requirements-dev.txt && pip install -e ./mlcube

pip install -e ./runners/mlcube_docker

@davidjurado davidjurado requested a review from a team as a code owner November 15, 2023 20:03
Copy link
Contributor

github-actions bot commented Nov 15, 2023

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@davidjurado davidjurado changed the title Add CUDA_VISIBLE_DEVICES enviroment variable when using the --gpus flag Add CUDA_VISIBLE_DEVICES environment variable when using the --gpus flag Nov 15, 2023
@sergey-serebryakov
Copy link
Contributor

@davidjurado Please merge latest changes from the master branch into your branch- they will fix unit tests.

@davidjurado
Copy link
Contributor Author

@sergey-serebryakov Thanks, I also had a bug in the implementation and now it's fixed.

Copy link
Contributor

@sergey-serebryakov sergey-serebryakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@sergey-serebryakov sergey-serebryakov merged commit 5f79b7a into mlcommons:master Jan 5, 2024
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants