Fixing command line interface for the run command.
#348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes bugs associated with the MLCube's `run` command: - It now uses correct option decorators from the `cli` (class Options) instead of deprecated decorators from the `__main__.py` file. - It now uses the `-P` option to correctly parse MLCube parameters that users provide on a command line. The latter particularly fixes the mlcommons#347 issue.
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes bugs associated with the MLCube's
runcommand:cli(class Options) instead of deprecated decorators from the__main__.pyfile.-Poption to correctly parse MLCube parameters that users provide on a command line.The latter particularly fixes the #347 issue. This commit also adjusts the python coding guidelines for the
__main__.pyfile.