-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI layout fixes #955
base: master
Are you sure you want to change the base?
UI layout fixes #955
Conversation
…to-resizing text to progress circle
…l instead of SizedBox()
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
…, and mustcallsuper
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI tests failed, and I suspect it's due to the UI changes. To debug the issue, you can run the tests locally using the command make flutter/test
.
Here is the error I got:
|
|
Did a complete uninstall and reinstall of the app resolve the issue? Did you test on an emulator or a real device? |
It's on any real device I used, uninstalling did nothing. I should mention that it works on emulators until partway through the tests where it crashes with no error message whatsoever. |
Update: it seems like the issue was that I was using an old version of |
@farook-edev, please resolve the merge conflicts and mark the pull request as ready once all the CI tests pass. Thanks. |
Quality Gate passedIssues Measures |
This PR fixes #942 by making sure the app does not clip or overlap elements on extreme screen sizes.
The primary culprit behind the clipping was the many Expanded elements, those were simplified and only the variable size items (such as lists) were allowed to expand.
One bug not mentioned in the issue was also fixed:
Also added fixes for the following issues as well: