Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce autoranging #257

Merged
merged 4 commits into from
Aug 10, 2021
Merged

Reintroduce autoranging #257

merged 4 commits into from
Aug 10, 2021

Conversation

psyhtest
Copy link
Contributor

@psyhtest psyhtest commented Aug 9, 2021

Fixes #253. Adding a new hash to the list of acceptable checksums allows submitters to use any commit on this r1.1 branch for v1.1 submission - both with max ranging (before this PR) and auto ranging (after this PR).

@psyhtest psyhtest requested a review from nvpohanh August 9, 2021 22:48
@github-actions
Copy link

github-actions bot commented Aug 9, 2021

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@psyhtest psyhtest requested review from s-idgunji and araghun August 9, 2021 22:48
@s-idgunji
Copy link
Contributor

Hi Anton (@psyhtest ) - Thanks. How does one select max vs auto if both are supported ? Or have we deprecated max with this ?

Copy link
Contributor

@nvpohanh nvpohanh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@psyhtest psyhtest merged commit 41e7d51 into r1.1 Aug 10, 2021
@psyhtest psyhtest deleted the autoranging branch August 10, 2021 17:29
@github-actions github-actions bot locked and limited conversation to collaborators Aug 10, 2021
@psyhtest
Copy link
Contributor Author

Sachin (@s-idgunji) Every submitter needs to clone the r1.1 branch:

$ git clone https://github.com/mlcommons/power-dev/commits/r1.1 power-dev-r1.1

If they do it now:

  • If they want to use auto ranging (the r1.0 behaviour and the new default behaviour), they should do nothing.
  • If they want to use max ranging (the r1.1 behaviour at the time the random seeds got distributed), they should do "downgrade":
$ cd power-dev-r1.1
$ git checkout 020bd3cb33e

(020bd3cb33e is the hash of the last commit on the r1.1 branch with the max ranging behaviour.)

If they did it before today:

  • If they want to use auto ranging, they should do "upgrade":
$ cd power-dev-r1.1
$ git pull
  • If they want to use max ranging, they should do nothing.

Results obtained with either approach will be accepted by the checker. Does it make sense?

In the future, we should discuss having explicit options:

  • Auto ranging (default)?
  • Max ranging
  • User-selected ranging (without the need for a ranging run).

@s-idgunji
Copy link
Contributor

@psyhtest Thanks for the write up It's likely that some submitters have used versions prior to your changes last week, so we want to make sure that those submitters do not face issues due to the version used. We can discuss this in our Power WG this week. I'm not sure how many will "do it now" given we're 3 days away from submission , but we can discuss all options.

Sachin (@s-idgunji) Every submitter needs to clone the r1.1 branch:

$ git clone https://github.com/mlcommons/power-dev/commits/r1.1 power-dev-r1.1

If they do it now:

  • If they want to use auto ranging (the r1.0 behaviour and the new default behaviour), they should do nothing.
  • If they want to use max ranging (the r1.1 behaviour at the time the random seeds got distributed), they should do "downgrade":
$ cd power-dev-r1.1
$ git checkout 020bd3cb33e

(020bd3cb33e is the hash of the last commit on the r1.1 branch with the max ranging behaviour.)

If they did it before today:

  • If they want to use auto ranging, they should do "upgrade":
$ cd power-dev-r1.1
$ git pull
  • If they want to use max ranging, they should do nothing.

Results obtained with either approach will be accepted by the checker. Does it make sense?

In the future, we should discuss having explicit options:

  • Auto ranging (default)?
  • Max ranging
  • User-selected ranging (without the need for a ranging run).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants