-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reintroduce autoranging #257
Conversation
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
Hi Anton (@psyhtest ) - Thanks. How does one select max vs auto if both are supported ? Or have we deprecated max with this ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Sachin (@s-idgunji) Every submitter needs to clone the
If they do it now:
( If they did it before today:
Results obtained with either approach will be accepted by the checker. Does it make sense? In the future, we should discuss having explicit options:
|
@psyhtest Thanks for the write up It's likely that some submitters have used versions prior to your changes last week, so we want to make sure that those submitters do not face issues due to the version used. We can discuss this in our Power WG this week. I'm not sure how many will "do it now" given we're 3 days away from submission , but we can discuss all options.
|
Fixes #253. Adding a new hash to the list of acceptable checksums allows submitters to use any commit on this r1.1 branch for v1.1 submission - both with max ranging (before this PR) and auto ranging (after this PR).