🛡️ Sentinel: [HIGH] Fix path traversal in SetPortrait - #215
Conversation
🚨 Severity: HIGH
💡 Vulnerability: A path traversal vulnerability was present in `CustomEmployeeManager.SetPortrait` where unvalidated `employeeId` strings from external mods could be used in file path construction.
🎯 Impact: Allowed malicious mods to access arbitrary files on the user's system by crafting paths using `../` in the `employeeId` parameter when attempting to load portraits.
🔧 Fix: Added independent path traversal validation `IndexOfAny(Path.GetInvalidFileNameChars()) < 0 && !employeeId.Contains("..")` for the `employeeId` before constructing the file path, gracefully falling back to a default solid teal color if validation fails.
✅ Verification: Run `dotnet test` to verify the codebase functions as expected and verify that the `SetPortrait` method safely rejects identifiers containing path navigation characters.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
1 participant
🚨 Severity: HIGH
💡 Vulnerability: A path traversal vulnerability was present in
CustomEmployeeManager.SetPortraitwhere unvalidatedemployeeIdstrings from external mods could be used in file path construction.🎯 Impact: Allowed malicious mods to access arbitrary files on the user's system by crafting paths using
../in theemployeeIdparameter when attempting to load portraits.🔧 Fix: Added independent path traversal validation
IndexOfAny(Path.GetInvalidFileNameChars()) < 0 && !employeeId.Contains("..")for theemployeeIdbefore constructing the file path, gracefully falling back to a default solid teal color if validation fails.✅ Verification: Run
dotnet testto verify the codebase functions as expected and verify that theSetPortraitmethod safely rejects identifiers containing path navigation characters.PR created automatically by Jules for task 13849845764350633608 started by @mleem97