Skip to content

⚡ Bolt: Optimize Lua Server Module Lookups - #218

Open
mleem97 wants to merge 1 commit into
mainfrom
bolt/optimize-lua-server-module-3028841097241900931
Open

⚡ Bolt: Optimize Lua Server Module Lookups#218
mleem97 wants to merge 1 commit into
mainfrom
bolt/optimize-lua-server-module-3028841097241900931

Conversation

@mleem97

@mleem97 mleem97 commented Aug 4, 2026

Copy link
Copy Markdown
Owner

💡 What: Replaced O(N) FindObjectsOfType<Il2Cpp.Server> calls in LuaServerModule (get_all, repair, repair_all) with O(1) singletons from Il2Cpp.NetworkMap.instance (servers and brokenServers). Fallback logic maintained for uninitialized states.
🎯 Why: The original methods traverse all scene objects, allocating arrays and generating heavy GC pressure which degrades performance significantly, especially for queries executed frequently by Lua mods.
📊 Impact: Eliminates GC allocations and transforms time complexity from O(N) over scene objects to O(N) over exactly mapped devices.
🔬 Measurement: Verified compilation and executed tests using dotnet build and dotnet test.


PR created automatically by Jules for task 3028841097241900931 started by @mleem97

Replaced O(N) `FindObjectsOfType<Il2Cpp.Server>` calls in `LuaServerModule` (`get_all`, `repair`, `repair_all`) with O(1) singletons from `Il2Cpp.NetworkMap.instance` (`servers` and `brokenServers`). Fallback logic maintained for uninitialized states.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@codacy-production

Copy link
Copy Markdown

Not up to standards ⛔

🔴 Issues 1 high

Alerts:
⚠ 1 issue (≤ 0 issues of at least minor severity)

Results:
1 new issue

Category Results
Security 1 high

View in Codacy

🟢 Metrics 19 complexity · 3 duplication

Metric Results
Complexity 19
Duplication 3

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant