Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix Models UI #16

Merged
merged 4 commits into from
Apr 10, 2024
Merged

fix: fix Models UI #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aa55d4d
fix: make username case insensitive
kharkevich Apr 10, 2024
dfaa186
fix: make username case insensitive (#14)
kharkevich Apr 10, 2024
4d1dafb
fix: remove extra field from API response
kharkevich Apr 10, 2024
2c4a490
fix: remove extra field from API response (#15)
kharkevich Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions mlflow_oidc_auth/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ def authenticate_request_basic_auth() -> Union[Authorization, Response]:
_set_is_admin(True)
_logger.debug("User %s authenticated", username)
return True
if store.authenticate_user(username, password):
if store.authenticate_user(username.lower(), password):
_set_username(username)
_logger.debug("User %s authenticated", username)
return True
Expand Down Expand Up @@ -331,7 +331,7 @@ def callback():
_set_is_admin(False)

# Store the user data in the session.
_set_username(email)
_set_username(email.lower())
# Create user due to auth
create_user()
return redirect(url_for("oidc_ui"))
Expand Down Expand Up @@ -454,7 +454,6 @@ def get_models():
"name": model.name,
"tags": model.tags,
"description": model.description,
"latest_versions": model.latest_versions,
"aliases": model.aliases,
}
for model in registered_models
Expand Down
1 change: 0 additions & 1 deletion web-ui/src/app/shared/interfaces/models-data.interface.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import { PermissionEnum } from 'src/app/core/configs/permissions';
export interface ModelModel {
aliases: Record<string, unknown>;
description: string;
latest_versions: any[];
name: string;
tags: Record<string, unknown>;
}
Expand Down
Loading