Upgrade to LLVM 21 #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ausbin
force-pushed
the
feature/llvm21
branch
from
59dbc79 to
443e646
Compare
|
@ausbin Can you fix the formatting job? Thanks! |
auto-merge was automatically disabled
September 20, 2025 04:36
Head branch was pushed to by a user without write access
ausbin
force-pushed
the
feature/llvm21
branch
from
443e646 to
abdde97
Compare
ausbin
force-pushed
the
feature/llvm21
branch
from
abdde97 to
53518f3
Compare
|
@raviqqe I think I fixed it, thanks for the heads up |
|
Thank you for the upgrade changes! |
|
Thanks for merging. I'm grateful to depend on projects that are so actively maintained |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo testpasses at least. Although I also updatedsetup.sh, it looks likellvm@21may not exist in Homebrew yet. @femtomc's changes in mlir-rs/mlir-sys#71 suggest an alternative way to install LLVM in CI.Still, this works end-to-end with Melior for my use cases when combined with mlir-rs/mlir-sys#71 and mlir-rs/melior#731, if that is useful to know.
I don't know if this warrants a version bump as #25 did (seems like the maintainer's call)
(Succeeds #28 which I made from the wrong branch)